fix(client): Some mcp server need default env(#393, #196) #394
+71
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontextprotocol#393, modelcontextprotocol#196) Signed-off-by: sunrabbit123 <[email protected]>
sunrabbit123
changed the title
sunrabbit123
commented
Apr 24, 2025
src/client/stdio.test.ts
Outdated
| test("should work with actual node mcp server", async () => { | ||
| const client = new StdioClientTransport({ | ||
| command: "npx", | ||
| args: ["-y", "@wrtnlabs/calculator-mcp"], |
There was a problem hiding this comment.
it's the simple mcp server
i make it for test
There was a problem hiding this comment.
There was a problem hiding this comment.
we should not be using real servers in tests
sunrabbit123
added a commit
to wrtnlabs/mcp-bundler
that referenced
this pull request
Apr 24, 2025
…led(modelcontextprotocol/typescript-sdk#394) Signed-off-by: sunrabbit123 <[email protected]>
ihrpr
requested changes
Apr 28, 2025
src/client/stdio.test.ts
Outdated
| test("should work with actual node mcp server", async () => { | ||
| const client = new StdioClientTransport({ | ||
| command: "npx", | ||
| args: ["-y", "@wrtnlabs/calculator-mcp"], |
There was a problem hiding this comment.
we should not be using real servers in tests
Signed-off-by: sunrabbit123 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ref: #393, #196
How Has This Been Tested?
npm run testBreaking Changes
We now always include the default environment variables when executing.
Types of changes
Checklist
Additional context